One Year of PullReview

Candles spell out the traditional English birt...

(Photo credit: Wikipedia)

I don’t scale

Two years ago, I was still employed as team leader of an architecture team in a mid-sized company. The pay was good (this is Belgium, so not stellar, but clearly good), we had our share of interesting projects and the colleagues were nice. That team leader position has arrived as a “natural” evolution from junior developer to senior and architect.

My days were less and less about building software and more and more about helping people build software. That was great as I could impact the delivery of multiple projects, not only my own. Now this had limits too – there is only 8 hours (or 10, or 12, but anyway) in a day.

We started 8th color with the idea of making it a company “by developers, for developers”, but also a product company – as a product was the only way to scale.

Because, I need to confess: I don’t scale.

Statistics

We started to work on PullReview in February of this year. We got our first alpha users in June and opened it to the world last October, so it is more like 3-6 months of usage. Anyway, I found interesting to extract some stats from our database.

During this period:

  • We’ve generated 22 988 code reviews
  • We’ve identified 40+M violations based on 266 different rules
  • Our 453 users have viewed 1357 code reviews (875 on feature branches, 482 on integration branches)
  • Among the rules, the most violated were as expected style rules: The infamous “prefer single quoted string when you don’t need interpolation”, of course, but also a lot of Ruby 1.8 hash syntax remaining. Be careful: style matters.
  • Two non style issues were quite prominent: missing documentation and duplicated code. We spoke previously about how duplication is a rampant disease.
  • Our top security concern identified is still Mass Assignment. For all the publicity it received, looks like it is still a danger today. Hopefully this will get better with more people migrating to Rails 4.0 and strong parameters.
  • Speaking of Rails related issues: we found that usage of instance variables in partials is still common. We talked about abusing partials in a previous post.

PullReview does scale

Not in the “let’s get 100M ruby developers here” sense. This is just the beginning for us and those numbers are still quite low.

But in my previous 8 years of software development, even with a good amount of it dedicated to coaching/helping people, I don’t think I managed to do 1 000 code reviews.

Summary: I’m happy to contribute to the quality of the code that our users are writing. To them – thanks for trying us.

Enhanced by Zemanta




6 thoughts on “One Year of PullReview

  1. Alex Reis

    Hi Martin,

    I feel honoured to have been one of the first alpha users of Pull Review. Thanks for this fantastic tool, your blog posts over the past year, and the amount I learned from all the knowledge you guys built into the tool.

    I hope you conquer the (ruby) world in 2014!

    Alex

    Reply
    1. Martin Post author

      Hi Alex!
      The honour is all ours. Thanks for your help, insights and kind words.

      (about the world conquest: shhh, this is supposed to be a secret).

      Martin

      Reply

Leave a Reply

Your email address will not be published. Required fields are marked *

You may use these HTML tags and attributes: <a href="" title=""> <abbr title=""> <acronym title=""> <b> <blockquote cite=""> <cite> <code> <del datetime=""> <em> <i> <q cite=""> <strike> <strong>